Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(decisions): fix typos #4591

Merged
merged 2 commits into from
Nov 13, 2022
Merged

docs(decisions): fix typos #4591

merged 2 commits into from
Nov 13, 2022

Conversation

rojvv
Copy link
Contributor

@rojvv rojvv commented Nov 13, 2022

Closes: N/A

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: ec40e57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 13, 2022

Hi @roj1512,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 13, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title chore(docs): fix two small typos docs(decisions): fix typos Nov 13, 2022
@MichaelDeBoey MichaelDeBoey merged commit ad921e9 into remix-run:main Nov 13, 2022
@rojvv rojvv deleted the patch-1 branch November 14, 2022 05:28
midgleyc pushed a commit to midgleyc/remix that referenced this pull request Nov 15, 2022
@rojvv @midgleyc
docs(decisions): fix typos (remix-run#4591)
3ca2706
MichaelDeBoey pushed a commit to MichaelDeBoey/remix that referenced this pull request Nov 17, 2022
@rojvv @MichaelDeBoey
docs(decisions): fix typos (remix-run#4591)
4b186e7
kentcdodds pushed a commit that referenced this pull request Dec 15, 2022
@rojvv @kentcdodds
docs(decisions): fix typos (#4591)
4cb765c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@machour machour Awaiting requested review from machour

Assignees

@mcansh mcansh

Labels
CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rojvv @MichaelDeBoey @mcansh